Mt refactor #135
Merged
Mt refactor #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial commit * structured + impl * Base merkle tree impl * merkle_tree_impl * generic indextype * Refactored code for further SMT impl. * Batch insertion implementation. * Major refactoring & forget implementation. * Remember implemented. * cargo fmt * Big refactor. Leaf now digest index to prevent forge attack. * unit test for Forgettable merkle tree. * cleanup * Clear Arity & replace F::zero() with default() * trait bound refactor * New example. * cargo fmt * More example. * ElementType->Element; rename trait, impl and module; remove missing license check * IndexType refactor * Refactor DigestAlgorithm * Pull out Element,Index,NodeValue as traits; add trait bound to unconstrainted generic struct/fn * Refactor capacity interface * Renaming & better crate import. * var renaming * MerkleProof API refactor Co-authored-by: Alex Xiong <alex.xiong.tech@gmail.com>
* A new macro for general merkle tree implementation * Better trait bound for data types * New Universal Merkle tree implementation, including non-membership proof * Better comments for examples.
fkrell
reviewed
Nov 14, 2022
jbearer
reviewed
Nov 14, 2022
|
@mrain Let's change this PR from a draft to a ready-for-review PR. |
tessico
reviewed
Nov 16, 2022
prelude now includes 2 canonical instantiation of rescue merkle tree.
jbearer
reviewed
Nov 21, 2022
jbearer
previously approved these changes
Nov 21, 2022
alxiong
reviewed
Nov 22, 2022
alxiong
reviewed
Nov 22, 2022
alxiong
reviewed
Nov 22, 2022
alxiong
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #88
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer