BugFix: BasemapGallery loading demo data in production release #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In `BasemapGallery.Appearance.cs`, the visibility of `PART_LoadingScrim` Grid has been set to `False`. - The `LoadBasemaps` method in `BasemapGallery.cs` and `BasemapGallery.Windows.cs` has been removed and its functionality has been moved to the `BasemapGallery_Loaded` method. - In `BasemapGalleryItem.cs`, the `Equals` method has been updated to check for equality of `BaseLayers` count and existence of all layers in `Basemap` in the `other` object, in addition to the existing checks.
dotMorten
reviewed
Jun 11, 2024
src/Toolkit/Toolkit.UI.Controls/BasemapGallery/BasemapGallery.Windows.cs
Outdated
Show resolved
Hide resolved
dotMorten
reviewed
Jun 11, 2024
src/Toolkit/Toolkit/UI/Controls/BasemapGallery/BasemapGalleryItem.cs
Outdated
Show resolved
Hide resolved
dotMorten
reviewed
Jun 12, 2024
src/Toolkit/Toolkit/UI/Controls/BasemapGallery/BasemapGalleryItem.cs
Outdated
Show resolved
Hide resolved
prathameshnarkhede
requested review from
mstefarov and
dotMorten
and removed request for
mstefarov and
dotMorten
dotMorten
reviewed
Jun 14, 2024
src/Toolkit/Toolkit/UI/Controls/BasemapGallery/BasemapGalleryItem.cs
Outdated
Show resolved
Hide resolved
dotMorten
approved these changes
Jun 14, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
mstefarov
approved these changes
Jun 18, 2024
prathameshnarkhede
deleted the
pratham/566-basemapgallery-loading-demo-data-in-production-release
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue #566
Description
This pull request includes several updates to the
BasemapGalleryandBasemapGalleryItemclasses. Here are the key changes:BasemapGallery.Appearance.cs: The visibility of thePART_LoadingScrimGrid has been set to False. This change will hide the loading scrim by default, providing a cleaner user interface while the basemaps are loading.LoadBasemapsmethod: TheLoadBasemapsmethod previously present in bothBasemapGallery.csandBasemapGallery.Windows.cshas been removed. Its functionality has been integrated into theBasemapGallery_Loadedmethod. This change streamlines the loading process and reduces code duplication.BasemapGalleryItem.cs: The Equals method in this class has been updated. In addition to the existing checks, it now also verifies the equality of theBaseLayerscount and checks for the existence of all layers inBasemapin theotherobject. This enhancement ensures a more thorough comparison ofBasemapGalleryIteminstances.These updates aim to improve the efficiency of the basemap loading process and the accuracy of basemap item comparisons. Please review the changes and let me know if you have any questions or feedback.