Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused qt5compat module #1776

Merged
merged 1 commit into from
Jan 16, 2025
Merged

remove unused qt5compat module #1776

merged 1 commit into from
Jan 16, 2025

Conversation

GuillaumeBelz
Copy link
Contributor

@GuillaumeBelz GuillaumeBelz commented Jan 16, 2025 •
edited
Loading

Description

remove unused qt5compat module

Type of change

  • Bug fix
  • New sample implementation
  • Sample viewer enhancement
  • Other enhancement

Platforms tested on:

  • Windows
  • Android
  • Linux
  • macOS
  • iOS

Checklist

  • Runs and compiles on all active platforms as a standalone sample
  • Runs and compiles in the sample viewer(s)
  • Branch is up to date with the latest main/v.next
  • All merge conflicts have been resolved
  • Self-review of changes
  • There are no warnings related to changes
  • No unrelated changes have been made to any other code or project files
  • Code is commented with correct formatting (CTRL+i)
  • All variable and method names are camel case
  • There is no leftover commented code
  • Screenshots are correct size and display in description tab (500px by 500px, platform agnostic)
  • If adding a new sample, it is added to the sample viewer
  • Cherry-picked to Main branch (if applicable)

@GuillaumeBelz GuillaumeBelz marked this pull request as draft January 16, 2025 17:19
@GuillaumeBelz GuillaumeBelz self-assigned this Jan 16, 2025
@GuillaumeBelz GuillaumeBelz changed the title unused remove unused qt5compat module Jan 16, 2025
JamesMBallard
JamesMBallard approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@JamesMBallard JamesMBallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good as long as there are no usages.

@GuillaumeBelz
Copy link
Contributor Author

Looks good in toolkit and samples

@GuillaumeBelz GuillaumeBelz marked this pull request as ready for review January 16, 2025 18:39
@GuillaumeBelz GuillaumeBelz merged commit 40ef8d1 into v.next Jan 16, 2025
@GuillaumeBelz GuillaumeBelz deleted the guil8553/remove-qt5compat branch January 16, 2025 18:39
GuillaumeBelz added a commit that referenced this pull request Jan 23, 2025
@GuillaumeBelz
Merge branch 'v.next' into guil8553/font
a12fe0e 
* v.next: (28 commits)
  Bump up the minimum versions. (#1778)
  Fix deprecated Qt API usages. (#1777)
  Workaround for iOS. (#1775)
  unused (#1776)
  snap geometry sample fixes (#1773)
  Update README.metadata.json (#1772)
  jared/200.7.0 (#1770)
  Split apart connection logic from permission requests logic (#1764)
  Bluetooth requirement is mobile only for indoors. (#1765)
  Sample viewer and the indoors sample must specify bluetooth manually now. (#1763)
  Bri12415/5917 android context (#1762)
  Update README to include haptics (#1761)
  Fix find place sample (#1758)
  Change all references of `DisplayGrid` to `ShowGrid` (#1759)
  Tan11389/scene grid app update (#1754)
  Fix ifdef condition (#1757)
  Update samples to request permissions (#1753)
  These paths have changed. (#1755)
  Update snap geometry edits sample (#1752)
  Use 200.6 ENC data. (#1751)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesMBallard JamesMBallard JamesMBallard approved these changes

Assignees

@GuillaumeBelz GuillaumeBelz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeBelz @JamesMBallard