Skip to content

Commit

Permalink
refactor: rename esriGeometryType interface GeometryType
Browse files Browse the repository at this point in the history
AFFECTS PACKAGES:
@esri/arcgis-rest-common-types
@esri/arcgis-rest-feature-service

BREAKING CHANGE:
rename esriGeometryType interface GeometryType
  • Loading branch information
jgravois committed Apr 11, 2019
1 parent 2839558 commit 1057850
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions packages/arcgis-rest-common-types/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export interface IEnvelope extends IGeometry {
/**
*
*/
export type esriGeometryType = // why is this type camelCased?
export type GeometryType = // why is this type camelCased?
| "esriGeometryPoint"
| "esriGeometryMultipoint"
| "esriGeometryPolyline"
Expand Down Expand Up @@ -171,7 +171,7 @@ export interface IFeatureSet extends IHasZM {
objectIdFieldName?: string; // optional
globalIdFieldName?: string; // optional
displayFieldName?: string; // optional
geometryType?: esriGeometryType; // for feature layers only
geometryType?: GeometryType; // for feature layers only
spatialReference?: ISpatialReference; // for feature layers only.
fields?: IField[];
features: IFeature[];
Expand Down
4 changes: 2 additions & 2 deletions packages/arcgis-rest-common-types/src/webmap.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
IField,
IExtent,
ISpatialReference,
esriGeometryType,
GeometryType,
IHasZM,
IFeature,
IGeometry,
Expand Down Expand Up @@ -836,7 +836,7 @@ export interface ILayerDefinition extends IHasZM {
/** An array of field objects containing information about the attribute fields for the feature collection or layer. */
fields?: IField[];
/** A string defining the type of geometry. Possible geometry types are: esriGeometryPoint, esriGeometryMultipoint, esriGeometryPolyline, esriGeometryPolygon, and esriGeometryEnvelope. */
geometryType?: esriGeometryType;
geometryType?: GeometryType;
/** The unique identifier for a feature or table row within a geodatabase. */
globalIdField?: string;
/** Indicates whether attachments should be loaded for the layer. */
Expand Down
4 changes: 2 additions & 2 deletions packages/arcgis-rest-feature-service/src/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Apache-2.0 */

import {
esriGeometryType,
GeometryType,
SpatialRelationship,
IGeometry,
ISpatialReference
Expand All @@ -11,7 +11,7 @@ import {
export interface ISharedQueryParams {
where?: string;
geometry?: IGeometry;
geometryType?: esriGeometryType;
geometryType?: GeometryType;
// NOTE: either WKID or ISpatialReference
inSR?: string | ISpatialReference;
spatialRel?: SpatialRelationship;
Expand Down
4 changes: 2 additions & 2 deletions packages/arcgis-rest-feature-service/src/queryRelated.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
ISpatialReference,
IFeature,
IHasZM,
esriGeometryType,
GeometryType,
IField
} from "@esri/arcgis-rest-common-types";

Expand Down Expand Up @@ -41,7 +41,7 @@ export interface IRelatedRecordGroup {
*/

export interface IQueryRelatedResponse extends IHasZM {
geometryType?: esriGeometryType;
geometryType?: GeometryType;
spatialReference?: ISpatialReference;
fields?: IField[];
relatedRecordGroups: IRelatedRecordGroup[];
Expand Down

0 comments on commit 1057850

Please sign in to comment.