fix: add package.json files to builds for individual build types (#955)

* fix: add package.json files to builds for individual build types * chore: fix for different node versions
Esri · Mar 10, 2022 · c162125 · c162125
1 parent 54df4ca
commit c162125
Show file tree

Hide file tree

Showing 11 changed files with 43 additions and 10 deletions.
diff --git a/demos/node-common-js/package.json b/demos/node-common-js/package.json
@@ -6,6 +6,7 @@
   "license": "Apache-2.0",
   "main": "index.js",
   "scripts": {
+    "start": "node index.js",
     "test": "echo \"Error: no test specified\" && exit 1"
   },
   "dependencies": {

diff --git a/demos/node-es-modules/package.json b/demos/node-es-modules/package.json
@@ -7,6 +7,7 @@
   "type": "module",
   "main": "index.js",
   "scripts": {
+    "start": "node index.js",
     "test": "echo \"Error: no test specified\" && exit 1"
   },
   "dependencies": {

diff --git a/package.json b/package.json
@@ -9,7 +9,7 @@
     "build": "npm run build:esm && npm run build:cjs && npm run build:bundled",
     "build:esm": "ultra --no-pretty --silent --build -r --filter \"packages/*\" build:esm",
     "build:cjs": "ultra --no-pretty --silent --build -r --filter \"packages/*\" build:cjs",
-    "build:bundled": "ultra  --no-pretty --silent --build -r --filter \"packages/*\" build:bundled",
+    "build:bundled": "ultra --build -r --filter \"packages/*\" build:bundled",
     "dev:esm": "ultra -r --filter \"packages/*\" dev:esm",
     "dev:cjs": "ultra -r --filter \"packages/*\" dev:cjs",
     "dev:bundled": "ultra -r --filter \"packages/*\" dev:bundled",

diff --git a/packages/arcgis-rest-auth/package.json b/packages/arcgis-rest-auth/package.json
@@ -29,7 +29,9 @@
     "postbuild": "node ../../scripts/create-dist-package-jsons.js",
     "build:bundled": "rollup -c ../../rollup.js",
     "build:cjs": "tsc --outDir ./dist/cjs -m commonjs",
+    "postbuild:cjs": "node ../../scripts/create-dist-package-jsons.js",
     "build:esm": "tsc --outDir ./dist/esm --declaration",
+    "postbuild:esm": "node ../../scripts/create-dist-package-jsons.js",
     "dev": "npm-run-all --parallel dev:*",
     "dev:bundled": "rollup -w -c ../../rollup.js",
     "dev:cjs": "tsc -w --outDir ./dist/cjs -m commonjs",

diff --git a/packages/arcgis-rest-demographics/package.json b/packages/arcgis-rest-demographics/package.json
@@ -32,7 +32,9 @@
     "postbuild": "node ../../scripts/create-dist-package-jsons.js",
     "build:bundled": "rollup -c ../../rollup.js",
     "build:cjs": "tsc --outDir ./dist/cjs -m commonjs",
+    "postbuild:cjs": "node ../../scripts/create-dist-package-jsons.js",
     "build:esm": "tsc --outDir ./dist/esm --declaration",
+    "postbuild:esm": "node ../../scripts/create-dist-package-jsons.js",
     "dev": "npm-run-all --parallel dev:*",
     "dev:bundled": "rollup -w -c ../../rollup.js",
     "dev:cjs": "tsc -w --outDir ./dist/cjs -m commonjs",

diff --git a/packages/arcgis-rest-feature-service/package.json b/packages/arcgis-rest-feature-service/package.json
@@ -31,7 +31,9 @@
     "postbuild": "node ../../scripts/create-dist-package-jsons.js",
     "build:bundled": "rollup -c ../../rollup.js",
     "build:cjs": "tsc --outDir ./dist/cjs -m commonjs",
+    "postbuild:cjs": "node ../../scripts/create-dist-package-jsons.js",
     "build:esm": "tsc --outDir ./dist/esm --declaration",
+    "postbuild:esm": "node ../../scripts/create-dist-package-jsons.js",
     "dev": "npm-run-all --parallel dev:*",
     "dev:bundled": "rollup -w -c ../../rollup.js",
     "dev:cjs": "tsc -w --outDir ./dist/cjs -m commonjs",

diff --git a/packages/arcgis-rest-geocoding/package.json b/packages/arcgis-rest-geocoding/package.json
@@ -31,7 +31,9 @@
     "postbuild": "node ../../scripts/create-dist-package-jsons.js",
     "build:bundled": "rollup -c ../../rollup.js",
     "build:cjs": "tsc --outDir ./dist/cjs -m commonjs",
+    "postbuild:cjs": "node ../../scripts/create-dist-package-jsons.js",
     "build:esm": "tsc --outDir ./dist/esm --declaration",
+    "postbuild:esm": "node ../../scripts/create-dist-package-jsons.js",
     "dev": "npm-run-all --parallel dev:*",
     "dev:bundled": "rollup -w -c ../../rollup.js",
     "dev:cjs": "tsc -w --outDir ./dist/cjs -m commonjs",

diff --git a/packages/arcgis-rest-portal/package.json b/packages/arcgis-rest-portal/package.json
@@ -32,7 +32,9 @@
     "postbuild": "node ../../scripts/create-dist-package-jsons.js",
     "build:bundled": "rollup -c ../../rollup.js",
     "build:cjs": "tsc --outDir ./dist/cjs -m commonjs",
+    "postbuild:cjs": "node ../../scripts/create-dist-package-jsons.js",
     "build:esm": "tsc --outDir ./dist/esm --declaration",
+    "postbuild:esm": "node ../../scripts/create-dist-package-jsons.js",
     "dev": "npm-run-all --parallel dev:*",
     "dev:bundled": "rollup -w -c ../../rollup.js",
     "dev:cjs": "tsc -w --outDir ./dist/cjs -m commonjs",

diff --git a/packages/arcgis-rest-request/package.json b/packages/arcgis-rest-request/package.json
@@ -32,7 +32,9 @@
     "postbuild": "node ../../scripts/create-dist-package-jsons.js",
     "build:bundled": "rollup -c ../../rollup.js",
     "build:cjs": "tsc --outDir ./dist/cjs -m commonjs",
+    "postbuild:cjs": "node ../../scripts/create-dist-package-jsons.js",
     "build:esm": "tsc --outDir ./dist/esm --declaration",
+    "postbuild:esm": "node ../../scripts/create-dist-package-jsons.js",
     "dev": "npm-run-all --parallel dev:*",
     "dev:bundled": "rollup -w -c ../../rollup.js",
     "dev:cjs": "tsc -w --outDir ./dist/cjs -m commonjs",

diff --git a/packages/arcgis-rest-routing/package.json b/packages/arcgis-rest-routing/package.json
@@ -31,7 +31,9 @@
     "postbuild": "node ../../scripts/create-dist-package-jsons.js",
     "build:bundled": "rollup -c ../../rollup.js",
     "build:cjs": "tsc --outDir ./dist/cjs -m commonjs",
+    "postbuild:cjs": "node ../../scripts/create-dist-package-jsons.js",
     "build:esm": "tsc --outDir ./dist/esm --declaration",
+    "postbuild:esm": "node ../../scripts/create-dist-package-jsons.js",
     "dev": "npm-run-all --parallel dev:*",
     "dev:bundled": "rollup -w -c ../../rollup.js",
     "dev:cjs": "tsc -w --outDir ./dist/cjs -m commonjs",

diff --git a/scripts/create-dist-package-jsons.js b/scripts/create-dist-package-jsons.js
@@ -3,15 +3,32 @@
  *
  * Inspired by: https://www.sensedeep.com/blog/posts/2021/how-to-create-single-source-npm-module.html
  */
-import { writeFile } from "fs/promises";
+import fs from "fs";
 import { join } from "path";
 
-writeFile(
-  join(process.cwd(), "dist", "esm", "package.json"),
-  JSON.stringify({ type: "module" }, null, 2)
-);
+const { writeFile, access } = fs.promises;
+const esmBuildFolder = join(process.cwd(), "dist", "esm");
 
-writeFile(
-  join(process.cwd(), "dist", "cjs", "package.json"),
-  JSON.stringify({ type: "commonjs" }, null, 2)
-);
+access(esmBuildFolder)
+  .then(() => {
+    writeFile(
+      join(esmBuildFolder, "package.json"),
+      JSON.stringify({ type: "module" }, null, 2)
+    );
+  })
+  .catch(() => {
+    // fail silently no ESM build folder was found.
+  });
+
+const cjsBuildFolder = join(process.cwd(), "dist", "cjs");
+
+access(cjsBuildFolder)
+  .then(() => {
+    writeFile(
+      join(cjsBuildFolder, "package.json"),
+      JSON.stringify({ type: "commonjs" }, null, 2)
+    );
+  })
+  .catch(() => {
+    // fail silently no CJS build folder was found.
+  });