-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to determine if a user session should be SSL-only #295
Comments
I think the way to do that would be to add add a
Then update I'd gladly accept such a pull request 😄 |
skitterm
pushed a commit
to skitterm/arcgis-rest-js
that referenced
this issue
Sep 20, 2018
…completeOAuth2 and used in to/fromCredential.
skitterm
pushed a commit
to skitterm/arcgis-rest-js
that referenced
this issue
Sep 20, 2018
Merged
PR submitted: #332 |
skitterm
pushed a commit
to skitterm/arcgis-rest-js
that referenced
this issue
Sep 20, 2018
skitterm
pushed a commit
to skitterm/arcgis-rest-js
that referenced
this issue
Sep 20, 2018
…urned or present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When authenticating with the OAuth implicit grant, a
ssl=true
key-value pair is returned as part of the OAuth callback's hash, when the organization is HTTPS-only. Based on that I can adjust everything to be strictly HTTPS when the organization requires it.However, when calling
userSession.toCredential()
,ssl
is alwaystrue
.Unless I'm mistaken, that makes it impossible to determine whether or not a session should be SSL-only (without manually reading the oauth callback hash for that value, of course).
Newbie idea, but a way to let
userSession
know ifssl
should betrue || false
would be to allow passing it in as a parameter incompleteOAuth2()
?The text was updated successfully, but these errors were encountered: