Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly change feature add, update and delete params to match REST API at some point #391

Closed
COV-GIS opened this issue Nov 14, 2018 · 3 comments

Comments

@COV-GIS
Copy link
Contributor

COV-GIS commented Nov 14, 2018

It's personal preference but adds, updates and deletes params really bother me for not being the REST params, e.g. features and objectIds respectively. I never fully understood the JS API having different param names from the REST API for queries and the like. I get it, outSpatialReference is more descriptive than outSR, but the rest of the param names here are REST API driven. I just like being able to look at the REST API docs and know I can pass any param as is.

I thought about it at the time the functions were added but didn't mention it. This would be a breaking change. So may never happen. But if there ever is a v2 candidate or other opening to change the param names I'd be happy to submit changes.

@jgravois
Copy link
Contributor

jgravois commented Nov 15, 2018

we actually already discussed this in Esri/hub.js#58 (and #137)

a PR that introduces features and objectIds and adds a deprecation warning when parsing what we already have would be most welcome.

@COV-GIS
Copy link
Contributor Author

COV-GIS commented Nov 15, 2018

I'm not the only one then.

Will do.

@COV-GIS
Copy link
Contributor Author

COV-GIS commented Nov 19, 2018

#396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants