Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update links to target the v4 docs #1150

Merged
merged 1 commit into from
Apr 16, 2024
Merged

docs: update links to target the v4 docs #1150

merged 1 commit into from
Apr 16, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Mar 30, 2024

fixes #1148

Thanks for your help with that @gavinr-maps !

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a801537) to head (ebbbb33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1150   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          177       177           
  Lines         3247      3247           
  Branches       551       551           
=========================================
  Hits          3247      3247           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gavinr-maps gavinr-maps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@patrickarlt this (finally) removes all instances of the old doc links (esri.github.io) from this repo, other than the link at the root README ("If you are on version 3, the previous documentation can be found at https://esri.github.io/arcgis-rest-js.")

@gavinr-maps gavinr-maps requested a review from patrickarlt April 1, 2024 18:41
@gavinr-maps gavinr-maps merged commit b2d07c8 into Esri:main Apr 16, 2024
4 checks passed
@vicb
Copy link
Contributor Author

vicb commented Apr 16, 2024

Thanks!

@vicb vicb deleted the docs branch April 16, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geocoding - README links to old documentation
4 participants