Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arcgis rest places package to use dev endpoints #1170

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

MonikaKanduri4525
Copy link
Contributor

@MonikaKanduri4525 MonikaKanduri4525 commented Jun 12, 2024

  • Added an endpoint param for places method in arcgis-rest-places package which allows to override the built in URL.
  • Added test cases

Pending:
comments for TypeDoc

Copy link
Contributor

@patrickarlt patrickarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MonikaKanduri4525 this looks great could you reset the demo URL and work on the typedoc comments based on my example?

I'm also going to ask @gavinr to review this as another contributor.

demos/node-places-api/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@gavinr-maps gavinr-maps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! In addition to Patrick's comments, just a few small things:

@MonikaKanduri4525
Copy link
Contributor Author

@patrickarlt @gavinr-maps - Thanks for the inputs, addressed the feedback here 161a784

Copy link
Contributor

@patrickarlt patrickarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I'll merge once tests pass.

@patrickarlt patrickarlt merged commit d0ca26d into Esri:main Jun 18, 2024
2 checks passed
gavinr-maps pushed a commit that referenced this pull request Jun 18, 2024
# @esri/arcgis-rest-places [1.1.0](https://github.com/Esri/arcgis-rest-js/compare/@esri/arcgis-rest-places@1.0.2...@esri/arcgis-rest-places@1.1.0) (2024-06-18)

### Features

* Allow arcgis rest places package to use dev endpoints ([#1170](#1170)) ([d0ca26d](d0ca26d))
gavinr-maps pushed a commit to gavinr-maps/arcgis-rest-js that referenced this pull request Jan 23, 2025
# [4.5.0](https://github.com/Esri/arcgis-rest-js/compare/@esri/arcgis-rest-portal@4.4.1...@esri/arcgis-rest-portal@4.5.0) (2025-01-23)

### Bug Fixes

* geocoder demo on windows [Esri#1140](Esri#1140) ([Esri#1177](Esri#1177)) ([bfd7ce9](Esri@bfd7ce9))
* migrate to esm.run ([Esri#1176](Esri#1176)) ([2323340](Esri@2323340))
* small change to trigger a catch-up release ([Esri#1169](Esri#1169)) ([650bca1](Esri@650bca1))

### Features

* add overwrite and isView options ([Esri#1175](Esri#1175)) ([949e341](Esri@949e341))
* Allow arcgis rest places package to use dev endpoints ([Esri#1170](Esri#1170)) ([d0ca26d](Esri@d0ca26d))
* make API keys work with all portal methods ([Esri#1186](Esri#1186)) ([1972413](Esri@1972413))
gavinr-maps pushed a commit to gavinr-maps/arcgis-rest-js that referenced this pull request Jan 23, 2025
# [4.3.0](https://github.com/Esri/arcgis-rest-js/compare/@esri/arcgis-rest-request@4.2.3...@esri/arcgis-rest-request@4.3.0) (2025-01-23)

### Bug Fixes

* geocoder demo on windows [Esri#1140](Esri#1140) ([Esri#1177](Esri#1177)) ([bfd7ce9](Esri@bfd7ce9))
* migrate to esm.run ([Esri#1176](Esri#1176)) ([2323340](Esri@2323340))
* small change to trigger a catch-up release ([Esri#1165](Esri#1165)) ([73aa677](Esri@73aa677))
* small change to trigger a catch-up release ([Esri#1166](Esri#1166)) ([26c33b1](Esri@26c33b1))
* small change to trigger a catch-up release ([Esri#1167](Esri#1167)) ([42fb211](Esri@42fb211))
* small change to trigger a catch-up release ([Esri#1168](Esri#1168)) ([5417fa7](Esri@5417fa7))
* small change to trigger a catch-up release ([Esri#1169](Esri#1169)) ([650bca1](Esri@650bca1))

### Features

* add overwrite and isView options ([Esri#1175](Esri#1175)) ([949e341](Esri@949e341))
* Allow arcgis rest places package to use dev endpoints ([Esri#1170](Esri#1170)) ([d0ca26d](Esri@d0ca26d))
* make API keys work with all portal methods ([Esri#1186](Esri#1186)) ([1972413](Esri@1972413))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants