Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(demos): jsapi integration demo shows more typical scenario #221

Merged
merged 2 commits into from
Jun 14, 2018
Merged

docs(demos): jsapi integration demo shows more typical scenario #221

merged 2 commits into from
Jun 14, 2018

Conversation

tomwayson
Copy link
Member

don't load arcgis-rest-js using dojo
call require() after loading item

AFFECTS PACKAGES:
@esri/jsapi-integration

@tomwayson
docs(demos): jsapi integration demo shows more typical scenario
2aa348c 
don't load arcgis-rest-js using dojo
call require() _after_ loading item

AFFECTS PACKAGES:
@esri/jsapi-integration
@tomwayson tomwayson requested a review from jgravois June 14, 2018 18:13
@tomwayson
Copy link
Member Author

TBH - I was half tempted to go all the way w/ this and actually use esri-loader and could tack on a follow on commit to do that if you think that's worthwhile.

jgravois
jgravois approved these changes Jun 14, 2018
View reviewed changes
Copy link
Contributor

@jgravois jgravois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it'd be overkill to use esri-loader in this demo.

that said, i think it'd be useful to discuss/link out from the demo README.

@coveralls
Copy link

coveralls commented Jun 14, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 1892ec9 on demo/more-typical-jsapi into db13178 on master.

@jgravois jgravois merged commit 0878793 into master Jun 14, 2018
@jgravois jgravois deleted the demo/more-typical-jsapi branch June 14, 2018 22:19
@tomwayson tomwayson mentioned this pull request Jun 19, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgravois jgravois jgravois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomwayson @coveralls @jgravois