Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(geocoder): Geocoder checks for null extent before assigning spatial ref. #377

Merged
merged 2 commits into from
Oct 31, 2018
Merged

fix(geocoder): Geocoder checks for null extent before assigning spatial ref. #377

merged 2 commits into from
Oct 31, 2018

Conversation

raykendo
Copy link
Contributor

Implemented a truthy check for an address candidate extent prior to assigning a spatial reference to
the extent object. Also updated tests to account for this change, as well as updated typescrypt
interfaces to work with the candidate data.

AFFECTS PACKAGES:
@esri/arcgis-rest-geocoder

ISSUES CLOSED: #376

@raykendo
fix(Fixes geocoder issue where it tries to assign a spatial reference…
bfad977 
… to a null extent): implemented

Implemented a truthy check for an address candidate extent prior to assigning a spatial reference to
the extent object. Also updated tests to account for this change, as well as updated typescrypt
interfaces to work  with the candidate data.

AFFECTS PACKAGES:
@esri/arcgis-rest-geocoder

ISSUES CLOSED: Esri#376
@coveralls
Copy link

coveralls commented Oct 31, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 40f56d6 on raykendo:master into afb8274 on Esri:master.

@raykendo raykendo changed the title fix(Fixes geocoder tries to assign a spatial reference to a null extent) fix(geocoder): Geocoder checks for null extent before assigning spatial ref. Oct 31, 2018
jgravois
jgravois approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@jgravois jgravois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you even supplied a commitizen formatted commit message.

thx for this contribution @raykendo! 💯🎉

@jgravois jgravois merged commit 41ac46c into Esri:master Oct 31, 2018
raykendo added a commit to raykendo/arcgis-rest-js that referenced this pull request Oct 31, 2018
@raykendo
Merge pull request #1 from Esri/master
99a4528 
Merge pull request Esri#377 from raykendo/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgravois jgravois jgravois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raykendo @coveralls @jgravois