getItemData() throws JSON error if data is empty #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 107 107
Lines 1616 1616
Branches 286 286
=========================================
Hits 1616 1616
Continue to review full report at Codecov.
|
pfcstyle
changed the title
|
@tomwayson why don't you merge this so we can get it in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If item data is empty, the error message is
SyntaxError: The string did not match the expected patternin safari.Please test the issue by the public item:
38503de66a594dd7a656c72a34c04183.