Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components from demo page not working properly in Edge #100

Closed
jcfranco opened this issue Aug 14, 2019 · 6 comments
Closed

Components from demo page not working properly in Edge #100

jcfranco opened this issue Aug 14, 2019 · 6 comments
Assignees
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug.

Comments

@jcfranco
Copy link
Member

Loading the demo page greets you with the following errors:

[object Error]: {description: "Object doesn't support property or method 'attachShadow'", message: "Object doesn't support property or method 'attachShadow'", number: -2146827850, stack: "TypeError: Object doesn't support property or method 'attachShadow' at FocusTrap (http://10.28.51.44:3339/build/calcite-modal.entry.js:151:9) at Anonymous function (http://10.28.51.44:3339/build/dom-860d8016-860d8016.js:19:811) at createElm (http://10.28.51.44:3339/build/core-b48dfbdd.js:666:9) at createElm (http://10.28.51.44:3339/build/core-b48dfbdd.js:684:17) at addVnodes (http://10.28.51.44:3339/build/core-b48dfbdd.js:755:13) at patch (http://10.28.51.44:3339/build/core-b48dfbdd.js:947:13) at renderVdom (http://10.28.51.44:3339/build/core-b48dfbdd.js:1105:5) at updateComponent (http://10.28.51.44:3339/build/core-b48dfbdd.js:1224:17) at update (http://10.28.51.44:3339/build/core-b48dfbdd.js:1197:26) at consumeTimeout (http://10.28.51.44:3339/build/core-b48dfbdd.js:121:13)"}

[object Error]: {description: "Unable to get property 'addEventListener' of undefined or null reference", message: "Unable to get property 'addEventListener' of undefined or null reference", number: -2146823281, stack: "TypeError: Unable to get property 'addEventListener' of undefined or null reference at prototype.componentDidLoad (http://10.28.51.44:3339/build/calcite-modal.entry.js:331:13) at safeCall (http://10.28.51.44:3339/build/core-b48dfbdd.js:1353:13) at postUpdateComponent (http://10.28.51.44:3339/build/core-b48dfbdd.js:1283:17) at updateComponent (http://10.28.51.44:3339/build/core-b48dfbdd.js:1265:5) at update (http://10.28.51.44:3339/build/core-b48dfbdd.js:1197:26) at consumeTimeout (http://10.28.51.44:3339/build/core-b48dfbdd.js:121:13) at flush (http://10.28.51.44:3339/build/core-b48dfbdd.js:145:5)"}

[object Error]: {description: "Unable to get property 'assignedElements' of undefined or null reference", message: "Unable to get property 'assignedElements' of undefined or null reference", number: -2146823281, stack: "TypeError: Unable to get property 'assignedElements' of undefined or null reference at get prototype.tabTitles (http://10.28.51.44:3339/build/calcite-tab-nav.entry.js:117:9) at prototype.componentDidRender (http://10.28.51.44:3339/build/calcite-tab-nav.entry.js:38:9) at safeCall (http://10.28.51.44:3339/build/core-b48dfbdd.js:1353:13) at postUpdateComponent (http://10.28.51.44:3339/build/core-b48dfbdd.js:1272:13) at prototype.s-init (http://10.28.51.44:3339/build/core-b48dfbdd.js:2040:21) at postUpdateComponent (http://10.28.51.44:3339/build/core-b48dfbdd.js:1321:21) at updateComponent (http://10.28.51.44:3339/build/core-b48dfbdd.js:1265:5) at update (http://10.28.51.44:3339/build/core-b48dfbdd.js:1197:26) at consumeTimeout (http://10.28.51.44:3339/build/core-b48dfbdd.js:121:13) at flush (http://10.28.51.44:3339/build/core-b48dfbdd.js:145:5)"}

[object Error]: {description: "Unable to get property 'addEventListener' of undefined or null reference", message: "Unable to get property 'addEventListener' of undefined or null reference", number: -2146823281, stack: "TypeError: Unable to get property 'addEventListener' of undefined or null reference at prototype.componentDidLoad (http://10.28.51.44:3339/build/calcite-modal.entry.js:331:13) at safeCall (http://10.28.51.44:3339/build/core-b48dfbdd.js:1353:13) at postUpdateComponent (http://10.28.51.44:3339/build/core-b48dfbdd.js:1283:17) at prototype.s-init (http://10.28.51.44:3339/build/core-b48dfbdd.js:2040:21) at postUpdateComponent (http://10.28.51.44:3339/build/core-b48dfbdd.js:1321:21) at updateComponent (http://10.28.51.44:3339/build/core-b48dfbdd.js:1265:5) at update (http://10.28.51.44:3339/build/core-b48dfbdd.js:1197:26) at consumeTimeout (http://10.28.51.44:3339/build/core-b48dfbdd.js:121:13) at flush (http://10.28.51.44:3339/build/core-b48dfbdd.js:145:5)"}

Tested using Edge Microsoft Edge 44.17763.1.0 and 42.17134.1.0 (thanks @driskull).

Assigning everyone so we can all go through our respective components to do some testing/fixing.

@jcfranco jcfranco added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Aug 14, 2019
@jcfranco jcfranco added this to the 1.0.0 milestone Aug 14, 2019
@paulcpederson
Copy link
Member

I think several of these are from tabs.

@jcfranco
Copy link
Member Author

Others may be affected. I only tested a few in isolation and noticed that <calcite-switch> isn't working properly for the following cases:

  • Switch with no wrapping label.
  • With a proxy input element and changes on click.

<calcite-radio-group> isn't working properly for the External inputs case.

@vcolavin
Copy link
Contributor

@jcfranco Interesting, I fixed an identical bug on calcite-checkbox, and I remember fixing it for calcite-switch too. Maybe I forgot to push that commit; I'll check.
#67

@vcolavin
Copy link
Contributor

https://github.com/Esri/calcite-components/blob/master/src/components/calcite-switch/calcite-switch.tsx#L109-L111

Looks like my fix for #67 exists in calcite-switch as well, so maybe this is a separate bug with a similar symptom.

jcfranco added a commit that referenced this issue Aug 14, 2019
paulcpederson added a commit that referenced this issue Aug 15, 2019
…ssues

Issue #100: Fix <calcite-radio-group> Edge issues.
@patrickarlt
Copy link
Contributor

I've resolved the issues with tabs as a part of #105.

@pr3tori4n pr3tori4n removed their assignment Aug 23, 2019
@macandcheese
Copy link
Contributor

Closing this as we've opened individual issues for all known Edge bugs, please add individual issues for anything else :)

@macandcheese macandcheese removed their assignment Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug.
Projects
None yet
Development

No branches or pull requests

8 participants