Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on calcite-fonts #86

Closed
patrickarlt opened this issue Aug 2, 2019 · 1 comment
Closed

Remove dependency on calcite-fonts #86

patrickarlt opened this issue Aug 2, 2019 · 1 comment
Assignees

Comments

@patrickarlt
Copy link
Contributor

Currently our dependency on calcite-fonts is a private repo. We probably need to remove it as a dependency from package.json and include it some other way like from a CDN.

@paulcpederson I'm assigning you because @julio8a said you might have a solution for this.

@paulcpederson
Copy link
Member

The solution is to just remove it, I don't think it's more complicated than that.

paulcpederson added a commit that referenced this issue Aug 3, 2019
patrickarlt pushed a commit that referenced this issue Aug 3, 2019
kumarGayu added a commit that referenced this issue Aug 4, 2019
* master: (32 commits)
  v1.0.0-beta.2
  cleanup build process
  v1.0.0-beta.1
  minor cleanup to test master push
  #86 - remove calcite-fonts (#89)
  Update focus style
  Button style updates
  Fixes typos, adds css vars, sets element dir
  add modals to stencil config
  Prep for beta 1 release (#85)
  calcite-colors: 1.3.1
  #9 - 🔲 integration of calcite-buttons into modals
  #9 - 🔲 modals
  Ensures alerts are full width on medium viewports
  Bumps stencil version
  Updates to alerts
  Adds dir and conditional styling for icons
  Updates to address PR feedback
  Adds calcite button component
  Issue #5: Rename group event.
  ...

# Conflicts:
#	src/index.html
#	stencil.config.ts
kumarGayu added a commit that referenced this issue Aug 4, 2019
* master: (32 commits)
  v1.0.0-beta.2
  cleanup build process
  v1.0.0-beta.1
  minor cleanup to test master push
  #86 - remove calcite-fonts (#89)
  Update focus style
  Button style updates
  Fixes typos, adds css vars, sets element dir
  add modals to stencil config
  Prep for beta 1 release (#85)
  calcite-colors: 1.3.1
  #9 - 🔲 integration of calcite-buttons into modals
  #9 - 🔲 modals
  Ensures alerts are full width on medium viewports
  Bumps stencil version
  Updates to alerts
  Adds dir and conditional styling for icons
  Updates to address PR feedback
  Adds calcite button component
  Issue #5: Rename group event.
  ...

# Conflicts:
#	package-lock.json
#	package.json
#	src/index.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants