Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for kebabified global attributes (enter-key-hint, input-mode) #9260

Closed
1 of 5 tasks
jcfranco opened this issue May 3, 2024 · 4 comments
Closed
1 of 5 tasks

Remove support for kebabified global attributes (enter-key-hint, input-mode) #9260

jcfranco opened this issue May 3, 2024 · 4 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Milestone
2024-11-26 - 3.0....

Comments

@jcfranco
Copy link
Member

jcfranco commented May 3, 2024

Description

#9245 fixed a regression caused by refactoring components to use global attributes, where kebab-cased global attributes were unintentionally removed.

This should be removed in a major release to allow us to fully rely on global attributes.

Proposed Advantages

Removal of workaround.

Which Component

input, input-text and input-number.

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@jcfranco jcfranco added refactor Issues tied to code that needs to be significantly reworked. breaking change Issues and pull requests with code changes that are not backwards compatible. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 3, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label May 3, 2024
@geospatialem geospatialem added this to the 2024-11-19 - Nov Release milestone Jun 28, 2024
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Jun 28, 2024
@jcfranco jcfranco mentioned this issue Oct 25, 2024
Open
6 tasks
@jcfranco jcfranco self-assigned this Nov 12, 2024
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Nov 12, 2024
@jcfranco jcfranco mentioned this issue Nov 13, 2024
Merged
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 13, 2024
@jcfranco
Copy link
Member Author

Blocked by #10310.

@jcfranco jcfranco added the blocked This issue is blocked by another issue. label Nov 13, 2024
@geospatialem geospatialem mentioned this issue Nov 13, 2024
Closed
jcfranco added a commit that referenced this issue Nov 15, 2024
@maxpatiiuk @jcfranco
@benelan @calcite-admin @renovate
refactor!: migrate to Lumina (#10482)
b2c9762 
**Related Issue:** #10310, #10481, #10399, #10405, #10491, #10434,
#10495, #9260

## Noteworthy changes

* components are now Lit-based
* removed `@storybook/test` and `@storybook/addon-interactions` as these
were not being actively used
* React deps bumped to v18
* Added default `scale` value to:
  * `action-bar`
  * `action-group`
  * `action-menu`
  * `action-pad`
* Path of extras will change to the following:
* `/dist/extras/vscode-data.json` ➡️
`/dist/docs/vscode.html-custom-data.json`
* backwards-compatible version is preserved to not break Intellisense
[described in the
doc](https://developers.arcgis.com/calcite-design-system/resources/frameworks/#visual-studio-intellisense)
	* `/dist/extras/docs-json.json` ➡️ `/dist/docs/docs.json` (internal)
* `/dist/extras/translations-json.json` ➡️
`/dist/docs/translations.json` (internal)
	* `/dist/extras/docs-json.d.ts` ❌ (removed, internal)

BREAKING CHANGE: 

* for a consistent development experience, components now convert `null`
to `undefined`, so developers will need to update code with strict null
checks
* removed the following `@esri/eslint-plugin-calcite-components` rules
as they are no longer valid:
	* `ban-props-on-host`
	* `enforce-ref-last-prop`
	* `require-event-emitter-type`

---------

Co-authored-by: JC Franco <jfranco@esri.com>
Co-authored-by: Ben Elan <no-reply@benelan.dev>
Co-authored-by: Calcite Admin <calcite-admin@esri.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. blocked This issue is blocked by another issue. labels Nov 15, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Nov 20, 2024

🍡 Verified locally using example from Franco: https://codepen.io/jcfranco/pen/QWeRebN?editors=1000
(the updated attributes should no longer show up on internal inputs)

@DitwanP DitwanP closed this as completed Nov 20, 2024
@DitwanP DitwanP removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Nov 20, 2024
@DitwanP DitwanP added the 4 - verified Issues that have been released and confirmed resolved. label Nov 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Issue #10310 has been closed, this issue is ready for re-evaluation.

cc @geospatialem,@DitwanP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @DitwanP