Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip: support clicking on a tooltip when a reference element is focused. #9827

Closed
2 of 6 tasks
driskull opened this issue Jul 22, 2024 · 2 comments
Closed
2 of 6 tasks

Tooltip: support clicking on a tooltip when a reference element is focused. #9827

driskull opened this issue Jul 22, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-07-31 - Jul ...

Comments

@driskull
Copy link
Member

Check existing issues

Actual Behavior

The issue is that when you are focused on a reference element and then click on a tooltip, the onfocusout is fired which closes the open tooltip before the click can occur.

We should have a solution to allow for the tooltip to be clicked and not closed

Expected Behavior

When focusing a reference element and then clicking a tooltip, the tooltip should not close.

Reproduction Sample

https://codepen.io/driskull/pen/RwzRKmb?editors=1000

Reproduction Steps

  1. open the console
  2. click on the button
  3. click on the tooltip
  4. the tooltip should remain open

Reproduction Version

2.10.0

Relevant Info

Notes: it works if just hovering the reference element and clicking the tooltip.

Basically, the focusout and click are fighting each other in this scenario

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

N/A
@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 22, 2024
@driskull driskull mentioned this issue Jul 22, 2024
Merged
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jul 22, 2024
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jul 22, 2024
driskull added a commit that referenced this issue Jul 23, 2024
@driskull
fix(tooltip): allow focusing on a reference element and then clicking…
7807e20 
… a tooltip. #9827
@driskull driskull mentioned this issue Jul 23, 2024
Closed
@driskull driskull assigned driskull and unassigned driskull Jul 23, 2024
@jcfranco jcfranco added this to the 2024-07-30 - Jul Release milestone Jul 23, 2024
@jcfranco jcfranco added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive 1 - assigned Issues that are assigned to a sprint and a team member. and removed impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive 0 - new New issues that need assignment. labels Jul 23, 2024
@jcfranco jcfranco assigned jcfranco and driskull and unassigned jcfranco Jul 23, 2024
@jcfranco jcfranco removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jul 23, 2024
@geospatialem geospatialem added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 29, 2024
@driskull driskull mentioned this issue Jul 29, 2024
Merged
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jul 29, 2024

🍡 Verified locally on dev

@DitwanP DitwanP closed this as completed Jul 29, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
4 participants
@jcfranco @driskull @geospatialem @DitwanP