Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tab Title] Fix hover styling in bordered appearance #9854

Closed
2 of 6 tasks
macandcheese opened this issue Jul 25, 2024 · 2 comments
Closed
2 of 6 tasks

[Tab Title] Fix hover styling in bordered appearance #9854

macandcheese opened this issue Jul 25, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone
Milestone
2024-07-31 - Jul ...

Comments

@macandcheese
Copy link
Contributor

Check existing issues

Actual Behavior

Follow up issue for hover style fix from #9666

Expected Behavior

I would not expect the bottom border in bordered and "top alignment" to cover the Tab container area:
Screenshot 2024-07-25 at 10 55 56 AM

Reproduction Sample

Reproduction Steps

Reproduction Version

Next

Relevant Info

No response

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 25, 2024
@macandcheese macandcheese self-assigned this Jul 25, 2024
@macandcheese macandcheese added this to the 2024-07-30 - Jul Release milestone Jul 25, 2024
@macandcheese macandcheese added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jul 25, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jul 25, 2024
@macandcheese macandcheese changed the title [Tab Title] Follow up style fix from Tab Title update [Tab Title] Fix hover styling in bordered appearance Jul 25, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jul 25, 2024
@macandcheese macandcheese mentioned this issue Jul 26, 2024
Merged
macandcheese added a commit that referenced this issue Jul 29, 2024
@macandcheese
fix(tab-title): Adjust hover styling for bordered Tab Title (#9867)
2c62917 
**Related Issue:** #9854 

## Summary
Adjusts some styling for the Tab Titles to ensure the correct visual are
applied in `bordered` mode. When we look at updating Tabs component to
use less "sub components" I think this setup can be adjusted - right now
the "tab border" for bordered comes from styling external to Tab Title.

@ashetland @SkyeSeitz I changed the way some of the border are
implemented, can you give this a look?
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned macandcheese Jul 29, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jul 29, 2024

🍡 Verified locally on dev
image

@DitwanP DitwanP closed this as completed Jul 29, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 29, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@macandcheese @github-actions
fix(tab-title): Adjust hover styling for bordered Tab Title (#9867)
a77cd27 
**Related Issue:** #9854 

## Summary
Adjusts some styling for the Tab Titles to ensure the correct visual are
applied in `bordered` mode. When we look at updating Tabs component to
use less "sub components" I think this setup can be adjusted - right now
the "tab border" for bordered comes from styling external to Tab Title.

@ashetland @SkyeSeitz I changed the way some of the border are
implemented, can you give this a look?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
3 participants
@macandcheese @geospatialem @DitwanP