test: fix window.getComputedStyle arguments
#10424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
changed the title
window.getComputedStyle arguments
| @@ -533,12 +533,12 @@ describe("calcite-button", () => { | |||
| buttonEl = await page.find("calcite-button >>> button"); | |||
| await buttonEl.focus(); | |||
| await page.waitForChanges(); | |||
| buttonFocusStyle = await buttonEl.getComputedStyle(":focus"); | |||
| buttonFocusStyle = await buttonEl.getComputedStyle(); | |||
There was a problem hiding this comment.
Nitpick: buttonFocusStyle can be changed to buttonStyle here to be more generic. Applies to other places.
jcfranco
added
the
skip visual snapshots
benelan
added a commit
that referenced
this pull request
Sep 30, 2024
…estone-estimates * origin/dev: (26 commits) test: fix `window.getComputedStyle` arguments (#10424) test(card): remove redundant spy and setup wrapper element (#10429) test(heading): avoid `newSpecPage` usage to ease Lumina migration (#10431) refactor(themed): drop broken, unused, regexp arg support (#10425) docs: component token description consistency (#10430) refactor: prevent mixed Sass mixed declaration warnings (#10426) deprecate: deprecate `enforce-ref-last-prop` rule (#10421) chore(actions): add custom `deprecate` type to semantic-pr check (#10427) chore(issue templates): add arcgis data pipelines to team dropdown (#10418) fix(tooltip): closed tooltips should not reappear (#10420) feat: add dashboard-graph (#10417) fix(input-time-zone): fix region mode quirks after update (#10413) fix(text-area): ensure border-color token doesn't override invalid styles (#10390) ci(changelog): add deprecation commits to changelog automation (#10346) fix: properly set aria attributes on components (#10404) feat: add parcel parameter (#10384) feat(alert): apply --calcite-alert-corner-radius to internal close button (#10388) feat(dialog, panel): Add css properties for background-color (#10387) fix: remove aria-disabled from components where necessary (#10374) feat(action-group, block, panel): add `menuPlacement` and `menuFlipPlacements` properties (#10249) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10369
Summary
This updates
getComputedStyleargs to:::aftervs:after