fix(action-menu): fix toggle logic when action-menu is reconnected
#11139
+55
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
added
the
no changelog entry
jcfranco
commented
Dec 23, 2024
| @@ -319,6 +319,8 @@ export class ActionMenu extends LitElement implements LoadableComponent { | |||
| "keydown", | |||
| this.menuButtonKeyDown, | |||
| ) /* TODO: [MIGRATION] If possible, refactor to use on* JSX prop or this.listen()/this.listenOn() utils - they clean up event listeners automatically, thus prevent memory leaks */; | |||
|
|
|||
| this.menuButtonEl = null; | |||
There was a problem hiding this comment.
Not clearing this reference would cause connectMenuButtonEl to bail since the references would remain the same.
driskull
approved these changes
Dec 23, 2024
| @@ -334,7 +336,10 @@ export class ActionMenu extends LitElement implements LoadableComponent { | |||
|
|
|||
| private setDefaultMenuButtonEl(el: Action["el"]): void { | |||
| this.defaultMenuButtonEl = el; | |||
| this.connectMenuButtonEl(); | |||
|
|
|||
| if (el) { | |||
There was a problem hiding this comment.
Seems like a lot of components might need this kind of if statement since this is similar to some other fixes 👍
There was a problem hiding this comment.
Agreed. I created #11093 to take a closer look, but it might be easier for the time being to return early when the reference element is null in all cases (preserves existing component logic based on Stencil lifecycle). WDYT?
There was a problem hiding this comment.
Yeah I think that might be the easiest and most consistent solution.
jcfranco
added
the
skip visual snapshots
github-actions
bot
added this to the 2025-01-30 - 3.0.0 Jan Breaking Change Release milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #10731
Summary
Fixes a regression caused by #10310 where the change to the internal popover to use
triggerDisabledwould no longer work when the component was reconnected.