Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(popover, dropdown, modal, pick-list-item, value-list-item)!: rename disable* properties #6036

Merged
merged 3 commits into from
Dec 14, 2022
Merged

refactor(popover, dropdown, modal, pick-list-item, value-list-item)!: rename disable* properties #6036

merged 3 commits into from
Dec 14, 2022

Conversation

driskull
Copy link
Member

@driskull driskull commented Dec 14, 2022 •
edited
Loading

BREAKING CHANGE: Renamed disable* properties.

  • Dropdown
    • Renamed the property disableCloseOnSelect, use closeOnSelectDisabled instead.
  • Modal
    • Renamed the property disableCloseButton, use closeButtonDisabled instead.
    • Renamed the property disableFocusTrap, use focusTrapDisabled instead.
    • Renamed the property disableOutsideClose, use outsideCloseDisabled instead.
    • Renamed the property disableEscape, use escapeDisabled instead.
  • PickListItem
    • Renamed the property disableDeselect, use deselectDisabled instead.
  • Popover
    • Renamed the property disableFlip, use flipDisabled instead.
    • Renamed the property disableFocusTrap, use focusTrapDisabled instead.
    • Renamed the property disablePointer, use pointerDisabled instead.
  • ValueListItem
    • Renamed the property disableDeselect, use deselectDisabled instead.

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Dec 14, 2022
@driskull
refactor(popover, dropdown, input-time-picker, modal, pick-list-item,…
71fdd3d 
… value-list-item)!: rename disable* properties. #4688
@driskull driskull changed the title refactor(popover, dropdown, input-time-picker, modal, pick-list-item, value-list-item)!: rename disable* properties refactor(popover, dropdown, modal, pick-list-item, value-list-item)!: rename disable* properties Dec 14, 2022
@driskull driskull marked this pull request as ready for review December 14, 2022 21:14
@driskull driskull requested a review from a team as a code owner December 14, 2022 21:14
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 14, 2022
benelan
benelan approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@driskull driskull merged commit 9b759fd into master Dec 14, 2022
@driskull driskull deleted the dris0000/disable-refactoring branch December 14, 2022 23:36
@github-actions github-actions bot added this to the 2023 January Priorities milestone Dec 14, 2022
benelan added a commit that referenced this pull request Dec 15, 2022
@benelan
Merge branch 'master' into benelan/delegatesFocus-no-mock-disabled
9030f13 
* master: (21 commits)
  1.0.0-next.685
  refactor(modal)!: Renamed property and updated values (#6054)
  1.0.0-next.684
  refactor(tab-nav, tab-title)!: remove `event.detail` payload from events (#6046)
  refactor(tree)!: remove `event.detail` payload from events (#6051)
  docs(changelog): fix breaking change indent levels (#6057)
  1.0.0-next.683
  refactor(pagination)!: remove `event.detail` payload from events (#6047)
  refactor(dropdown)!: remove `event.detail` payload from events (#6044)
  refactor(rating)!: remove `event.detail` payload from events (#6045)
  refactor(inline-editable,input,input-text,input-number)!: remove deprecated `intl*` properties (#6049)
  1.0.0-next.682
  refactor(scrim,rating,time-picker,input-time-picker,value-list)!: removed deprecated `intl*`properties (#6053)
  docs: update component READMEs (#6052)
  1.0.0-next.681
  refactor(chip,card,combobox,date-picker,flow,flow-item,filter, input-date-picker): remove deprecated `intl*` & accessible label properties (#6041)
  refactor(action,action-bar,action-group,action-pad,alert,block-section,block,button): remove deprecated `intl*` properties (#5982)
  1.0.0-next.680
  refactor(popover, dropdown, modal, pick-list-item, value-list-item)!: rename `disable*` properties (#6036)
  refactor(input-date-picker)!: Remove deprecated calciteDatePickerChange event (#6040)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

@eriklharper eriklharper eriklharper approved these changes

Assignees

@driskull driskull

Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 January Priorities
Development

Successfully merging this pull request may close these issues.
3 participants
@driskull @eriklharper @benelan