fix(stepper-item): no longer refer numberingSystem from neighbor stepper component #6380
Conversation
github-actions
bot
added
the
bug
| @@ -143,7 +143,8 @@ export class Stepper { | |||
| event.stopPropagation(); | |||
| } | |||
|
|
|||
| @Listen("calciteInternalStepperItemRegister") registerItem(event: CustomEvent): void { | |||
| @Listen("calciteInternalStepperItemRegister") | |||
| registerItem(event: CustomEvent): void { | |||
There was a problem hiding this comment.
made this change to avoid JSDOC warning . unrelated to the issue.
There was a problem hiding this comment.
yup. linting warning.
| @@ -153,7 +154,8 @@ export class Stepper { | |||
| event.stopPropagation(); | |||
| } | |||
|
|
|||
| @Listen("calciteInternalStepperItemSelect") updateItem(event: CustomEvent): void { | |||
| @Listen("calciteInternalStepperItemSelect") | |||
| updateItem(event: CustomEvent): void { | |||
There was a problem hiding this comment.
made this change to avoid JSDOC warning . unrelated to the issue.
| await stepper2.click(); | ||
| await page.waitForChanges(); | ||
| await stepper1.click(); | ||
| await page.waitForChanges(); |
There was a problem hiding this comment.
Main reason behind adding clicks is to make sure we reproduce the error state. Error state can appear on initial render.
anveshmekala
added
the
pr ready for visual snapshots
There was a problem hiding this comment.
Nice!
I believe the issue is with the formatter cache itself, but this is good for the issue at hand. Adding @benelan to take a look.
If this looks good to merge, @anveshmekala, can you create an issue to fix the cache?
| @@ -143,7 +143,8 @@ export class Stepper { | |||
| event.stopPropagation(); | |||
| } | |||
|
|
|||
| @Listen("calciteInternalStepperItemRegister") registerItem(event: CustomEvent): void { | |||
| @Listen("calciteInternalStepperItemRegister") | |||
| registerItem(event: CustomEvent): void { | |||
| {numberStringFormatter.numberFormatter.format(this.itemPosition + 1)}. | ||
| </div> | ||
| ) : null} | ||
| {this.numbered ? <div class="stepper-item-number">{this.renderNumbers()}.</div> : null} |
There was a problem hiding this comment.
We might want to move the numberStringFormatter check to the render block for all of its components to prevent similar bugs. It won't recreate a new NumberFormatter if the lang/numberingSystem is the same so putting the check in the render block won't be too expensive performance-wise.
I can do that in a follow up PR
Added an issue #6399. |
github-actions
bot
added this to the 2023 February Priorities - No breaking changes milestone
* origin/master: 1.0.4-next.5 fix(stepper-item): no longer refer numberingSystem from neighbor stepper component (#6380)
Related Issue: #6331
Summary
This PR will fix the issue of
steppercomponent's numbers being localized to thenumberingSystemspecified by neighboringsteppercomponent rendered in same page.