Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(input-number, input-text): remove unsupported boolean type from type prop doc #6394

Merged
merged 7 commits into from
Feb 3, 2023
Merged

docs(input-number, input-text): remove unsupported boolean type from type prop doc #6394

merged 7 commits into from
Feb 3, 2023

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Jan 31, 2023 •
edited
Loading

Related Issue: #6386

Summary

In the future, we will be removing the support of the boolean type for the icon prop on input-number and input-text as these don't have a default recommended icon for an unspecified icon attribute and result in unwanted spacing preceding the input.

For now though, since it is potentially a minor breaking change that could possibly be in use somewhere, we removed the boolean scenario from the documentation and marked it with a newly introduced custom @futureBreaking tag.

@Elijbet Elijbet requested a review from a team as a code owner January 31, 2023 05:45
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jan 31, 2023
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jan 31, 2023
@Elijbet Elijbet marked this pull request as draft January 31, 2023 20:36
@Elijbet Elijbet force-pushed the elijbet/6386-no-space-in-front-of-input-for-types-number-and-text branch from e332abe to ee5a1eb Compare February 2, 2023 06:01
@Elijbet Elijbet changed the title fix(input-number, input-text): removes unwanted space in input fix(input-number, input-text): marks the boolean type for icon attribute as @future-breaking Feb 2, 2023
@Elijbet Elijbet changed the title fix(input-number, input-text): marks the boolean type for icon attribute as @future-breaking fix(input-number, input-text): marks the boolean type for icon attribute as @future-breaking Feb 2, 2023
@Elijbet Elijbet marked this pull request as ready for review February 2, 2023 06:38
@Elijbet Elijbet added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 2, 2023
@Elijbet Elijbet changed the title fix(input-number, input-text): marks the boolean type for icon attribute as @future-breaking Docs: marks the boolean type for icon attribute as @futureBreaking Feb 3, 2023
@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Feb 3, 2023
@Elijbet Elijbet changed the title Docs: marks the boolean type for icon attribute as @futureBreaking docs: marks the boolean type for icon attribute as @futureBreaking Feb 3, 2023
@Elijbet Elijbet added docs Issues relating to documentation updates only. Calcite (dev) Issues logged by Calcite developers. and removed chore Issues with changes that don't modify src or test files. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. labels Feb 3, 2023
@Elijbet Elijbet changed the title docs: marks the boolean type for icon attribute as @futureBreaking docs(input-number, input-text): remove unsupported boolean type from type prop doc Feb 3, 2023
jcfranco
jcfranco approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@benelan benelan merged commit f69995e into master Feb 3, 2023
@benelan benelan deleted the elijbet/6386-no-space-in-front-of-input-for-types-number-and-text branch February 3, 2023 03:18
benelan added a commit that referenced this pull request Feb 3, 2023
@benelan
Merge remote-tracking branch 'origin/master' into benelan/add-setfocus
1d3f53d 
* origin/master:
  docs(input-number, input-text): remove unsupported boolean type from type prop doc (#6394)
  ci(release): lint readme and changelog before committing (#6406)
  ci: allow multiple product team labels (#6411)
@jcfranco jcfranco mentioned this pull request Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geospatialem geospatialem geospatialem left review comments

@jcfranco jcfranco jcfranco approved these changes

Assignees

@Elijbet Elijbet

Labels
Calcite (dev) Issues logged by Calcite developers. docs Issues relating to documentation updates only.
Projects
None yet
Milestone
2023 January Priorities Patch - Bugs ...
Development

Successfully merging this pull request may close these issues.
4 participants
@Elijbet @jcfranco @geospatialem @benelan