feat(pagination, split-button, dropdown, date-picker, action-group): add setFocus method #6438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add setFocus method
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
|
Keep forgetting to add this PR in as a result of our patch post 1.0 efforts Could we consider merging in for next week's release, @jcfranco? |
github-actions
bot
removed
the
Stale
jcfranco
approved these changes
Mar 27, 2023
| import { SLOTS } from "./resources"; | ||
|
|
||
| const actionGroupHTML = `<calcite-action-group scale="l"> | ||
| <calcite-action id="plus" slot="menu-actions" text="Add" icon="plus"></calcite-action> | ||
| <calcite-action id="banaa" slot="menu-actions" text="Banana" icon="banana"></calcite-action> |
| @@ -17,6 +17,11 @@ describe("calcite-date-picker", () => { | |||
| } | |||
| ])); | |||
|
|
|||
| it("focusable", async () => | |||
| focusable("<calcite-date-picker></calcite-date-picker>", { | |||
There was a problem hiding this comment.
Tip: focusable accepts the component tag name for simple setups: focusable("calcite-date-picker").
…ocus-revert * origin/master: (30 commits) fix(modal): prevent error when calling setFocus on a recently rendered and opened modal (`dist-custom-elements`) (#6666) fix(tile-select): fix click not firing in custom-elements build (#6665) fix(card): provide more meaningful screen reader label for selectable cards (deprecates `deselect` message override) (#6657) fix(pagination): add current page information for screen readers (#6637) chore: update jsbin sample to CC 1.0 breaking changes and latest jsapi version (#6651) feat(text-area): add calcite-text-area component (#5644) chore(release): 1.1.1-next.2 fix(tile): adds styling to `tile` where `link` is present for additional distinction (#6628) docs(input, input-number, input-text): api consistency across components (#6634) docs(accordion-item): add actions-start and actions-end slots (#6631) docs(modal): kebab-case slot names and sticky context (#6625) chore(release): 1.1.1-next.1 fix: restore form control validation in Safari (#6623) chore(linting): fix linting errors (#6613) build(deps): Bump eslint-plugin-react from 7.31.11 to 7.32.2 (#6619) build(deps): Bump eslint from 8.35.0 to 8.36.0 (#6620) build(deps): Bump @types/lodash-es from 4.17.6 to 4.17.7 (#6621) build: fix peer dependency resolution error (#6611) ci: update user-defined priority (#6609) build: update browserslist db (#6527) ...
benelan
added
the
pr ready for visual snapshots
github-actions
bot
added this to the 2023 April Priorities - No breaking changes milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5147
Summary
Adds the public
setFocusmethod to thedelegatesFocuscomponents that don't have it. See #5147 (comment)