feat(navigation): remove prefix nav for menu and menu-item #6774
Conversation
| describe("calcite-menu", () => { | ||
| it("renders", async () => renders("calcite-menu", { display: "flex" })); | ||
|
|
||
| it("honors hidden attribute", async () => hidden("calcite-menu")); |
There was a problem hiding this comment.
Do we want to try adding a11y tests at this point or wait for that?
There was a problem hiding this comment.
added a11y for menu-item and menu components.
src/components/menu/menu.tsx
Outdated
| @@ -36,7 +36,7 @@ export class CalciteNavMenu { | |||
| @Prop() label: string; | |||
|
|
|||
| // todo evaluate slotted content and determine if it is a nav menu item, then limit # rendered when auto-collapsing based on width of parent | |||
| @Prop({ mutable: true }) minCollapsedItems?; | |||
| @Prop() minCollapsedItems: boolean; | |||
There was a problem hiding this comment.
We can remove this, for the time being, until we add back the auto-collapse functionality?
There was a problem hiding this comment.
sure, removed.
|
|
||
| /** | ||
| * @internal | ||
| */ | ||
| @Prop({ mutable: true }) subMenuOpen = false; | ||
| @Prop({ mutable: true }) open = false; |
There was a problem hiding this comment.
I know this is internal - 2 questions - is open descriptive enough? And, should this be publicly documented (is there a reason a dev user might want to be able to toggle this? I could see it maybe being useful in layout="vertical" menu use cases.
There was a problem hiding this comment.
i gave a thought about changing it to open, the reason being consistency. Though it is internal, keeping it consistent will be useful if we choose to make it public in future as you mentioned for layout="vertical"
Related Issue: #6531
Summary
nav-menutomenuandnav-menu-itemtomenu-item.subMenuOpentoopenin menu-item.