ci: add type checking to github scripts #9851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
benelan
added
the
skip visual snapshots
jcfranco
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺
🕺☝️☝️☝️☝️🕺☝️🕺🕺🕺🕺🕺☝️🕺☝️🕺🕺🕺🕺🕺☝️🕺
🕺☝️🕺🕺☝️🕺☝️🕺🕺🕺🕺🕺☝️🕺☝️🕺🕺🕺🕺🕺☝️🕺
🕺☝️☝️☝️☝️🕺☝️🕺🕺☝️🕺🕺☝️🕺☝️🕺🕺☝️🕺🕺☝️🕺
🕺☝️🕺🕺☝️🕺☝️🕺☝️🕺☝️🕺☝️🕺☝️🕺☝️🕺☝️🕺☝️🕺
🕺☝️🕺🕺☝️🕺🕺☝️🕺🕺🕺☝️🕺🕺🕺☝️🕺🕺🕺☝️🕺🕺
🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺
🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺
🕺☝️🕺🕺🕺☝️🕺☝️🕺🕺🕺☝️🕺🕺☝️☝️☝️🕺🕺☝️☝️☝️🕺🕺☝️☝️☝️🕺☝️🕺
🕺🕺☝️🕺☝️🕺🕺☝️🕺🕺🕺☝️🕺☝️🕺🕺🕺🕺☝️🕺🕺🕺🕺☝️🕺🕺🕺🕺☝️🕺
🕺🕺🕺☝️🕺🕺🕺☝️🕺🕺🕺☝️🕺🕺☝️☝️🕺🕺🕺☝️☝️🕺🕺🕺☝️☝️🕺🕺☝️🕺
🕺🕺🕺☝️🕺🕺🕺☝️🕺🕺🕺☝️🕺🕺🕺🕺☝️🕺🕺🕺🕺☝️🕺🕺🕺🕺☝️🕺🕺🕺
🕺🕺🕺☝️🕺🕺🕺🕺☝️☝️☝️🕺🕺☝️☝️☝️🕺🕺☝️☝️☝️🕺🕺☝️☝️☝️🕺🕺☝️🕺
🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺
benelan
added a commit
that referenced
this pull request
Jul 29, 2024
**Related Issue:** #9851 ## Summary Fixes the case of environment variables in the workflow files, which I made uppercase in the GitHub scripts.
benelan
added a commit
that referenced
this pull request
Jul 29, 2024
**Related Issue:** #9851 ## Summary The PR I created for `actions/github-script` was merged.
calcite-admin
pushed a commit
that referenced
this pull request
Jul 30, 2024
## Summary - Add [`actions/github-script`](https://github.com/marketplace/actions/github-script) types - Add [`@octokit/webhook-types`](https://www.npmjs.com/package/@octokit/webhooks-types) for improved payload typing - Use JSDoc wizardry to typecheck the JavaScript files used by our workflows ## Notes I got a husky error when installing the `github-script` types. Here is a related issue: typicode/husky#851 Upgrading husky resolves the error, so I created a pull request: actions/github-script#482 I installed `github-script` using the PR number for now. We can unpin the PR once it's merged by re-installing via the [command in the doc](https://github.com/actions/github-script/#use-scripts-with-jsdoc-support): ```sh npm i -D @types/github-script@github:actions/github-script ```
calcite-admin
pushed a commit
that referenced
this pull request
Jul 30, 2024
**Related Issue:** #9851 ## Summary Fixes the case of environment variables in the workflow files, which I made uppercase in the GitHub scripts.
calcite-admin
pushed a commit
that referenced
this pull request
Jul 30, 2024
**Related Issue:** #9851 ## Summary The PR I created for `actions/github-script` was merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
actions/github-scripttypes@octokit/webhook-typesfor improved payload typingNotes
I got a husky error when installing the
github-scripttypes. Here is a related issue: typicode/husky#851Upgrading husky resolves the error, so I created a pull request: actions/github-script#482
I installed
github-scriptusing the PR number for now. We can unpin the PR once it's merged by re-installing via the command in the doc: