Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note on using proswap before running the MSI #18

Merged
merged 3 commits into from
Jun 9, 2021

Conversation

guillochon
Copy link
Contributor

Seems like a crucial bit of information to include so that people don't accidentally pollute the default environment.

Copy link
Collaborator

@cleebp cleebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the super late review: the deep learning installers are intended to install on top of the default arcgispro-py3 environment for most users. I agree that adding a note on using proswap to optionally install in a clone makes sense, if you can edit the wording a little bit to reflect this I'll approve 👍

make clear that environment switch is optional
@guillochon
Copy link
Contributor Author

Made the language a bit clearer that switching environments before installing is optional.

Copy link
Collaborator

@cleebp cleebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the edit!

@cleebp cleebp merged commit 69a1d3a into Esri:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants