This repository has been archived by the owner on Nov 6, 2024. It is now read-only.
Feature/enable preload #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: #7 (comment)
Update index.ts
|
LGTM. Only thing I can think of is maybe adding an |
|
Thanks for taking time to review @davetimmins - opened #14 for this. Thanks again @alexurquhart for your contributions and patience. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice work @alexurquhart in #10!
I've tested locally, and your code works. I made a few tweaks and am including those here for review before merging.
What do you think? @davetimmins? @jwasilgeo?
If this looks good, I'll merge in favor of #10.
resolves #7