Merge branch 'koopjs:master' into master

Esri · Aug 30, 2023 · f8354c9 · f8354c9
2 parents 2d1568c + 65be4a7
commit f8354c9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/.changeset/good-jobs-exercise.md b/.changeset/good-jobs-exercise.md
@@ -0,0 +1,5 @@
+---
+'@koopjs/koop-core': patch
+---
+
+- ensure constructor options are optional
diff --git a/packages/core/src/index.js b/packages/core/src/index.js
@@ -27,11 +27,11 @@ class Koop extends Events {
     this.pluginRoutes = [];
     this.outputs = [];
 
-    const { geoservicesDefaults } = options;
+    const { geoservicesDefaults } = this.config;
 
     this.register(geoservices, {
       logger: this.log,
-      authInfo: options?.authInfo || config.authInfo,
+      authInfo: this.config.authInfo,
       defaults: geoservicesDefaults
     });
 

diff --git a/packages/core/src/index.spec.js b/packages/core/src/index.spec.js
@@ -62,10 +62,15 @@ const providerFixtureRoutes = mockProviderDefinition.routes.reduce((acc, route)
 
 describe('Index tests', function () {
   describe('Koop instantiation', function () {
-    it('should instantiate Koop with config', function () {
+    it('should instantiate Koop with options', function () {
       const koop = new Koop({ foo: 'bar', logLevel: 'error' });
       koop.config.should.have.property('foo', 'bar');
     });
+
+    it('should instantiate Koop without options', function () {
+      const koop = new Koop();
+      koop.config.should.be.empty();
+    });
   });
 
   describe('Provider registration', function () {