Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: markdown link #33

Merged
merged 3 commits into from
Apr 11, 2024
Merged

feat: markdown link #33

merged 3 commits into from
Apr 11, 2024

Conversation

antoncoding
Copy link
Collaborator

TLDR

Parse markdown link,使用 html tag 取代

實作困難

本來想做 1 & 3,但是 1 比想像中難做,於是先做 3

  1. 目前的做法是先將 markdown parse 成 html file. 這之後如果要算字數決定是否 shorten text 的時候會遇到一些問題(例如要判斷 <a /> 不算在字數裡面),不能直接用 length 判斷。
  2. static file 難以做到 toggle 兩個不同的 content ,目前嘗試了一些做法都有問題,理想上希望可以完全靠 js & css 解決

@antoncoding antoncoding requested a review from slothservice April 8, 2024 05:08
Copy link
Contributor

@slothservice slothservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 變成超連結好看多了
Feel free to merge

@antoncoding antoncoding merged commit d2bb5ba into main Apr 11, 2024
1 check passed
@antoncoding antoncoding deleted the feat/markdown-link branch April 11, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants