teardown csm

EtherealEngine · Oct 4, 2023 · 9cf6df9 · 9cf6df9
1 parent 5fa7674
commit 9cf6df9
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/packages/engine/src/assets/csm/CSM.ts b/packages/engine/src/assets/csm/CSM.ts
@@ -378,6 +378,22 @@ export class CSM {
     addOBCPlugin(material, material.userData.CSMPlugin)
   }
 
+  teardownMaterial(mesh: Mesh): void {
+    const material = mesh.material as Material
+    if (!material.userData) material.userData = {}
+    if (material.userData.CSMPlugin) {
+      removeOBCPlugin(material, material.userData.CSMPlugin)
+      delete material.userData.CSMPlugin
+    }
+    if (material.defines) {
+      delete material.defines.USE_CSM
+      delete material.defines.CSM_CASCADES
+      delete material.defines.CSM_FADE
+    }
+    material.needsUpdate = true
+    this.shaders.delete(material)
+  }
+
   updateUniforms(): void {
     const far = Math.min(this.camera.far, this.maxFar)
     this.shaders.forEach(function (shader: ShaderType, material: Material) {

diff --git a/packages/engine/src/scene/systems/SceneObjectSystem.tsx b/packages/engine/src/scene/systems/SceneObjectSystem.tsx
@@ -175,6 +175,15 @@ function SceneObjectReactor(props: { entity: Entity; obj: Object3DWithEntity })
         csm.setupMaterial(child)
       }
     })
+
+    return () => {
+      obj.traverse((child: Mesh<any, Material>) => {
+        if (!child.isMesh) return
+        if (csm) {
+          csm.teardownMaterial(child)
+        }
+      })
+    }
   }, [shadowComponent?.cast, shadowComponent?.receive, csm])
 
   return null