Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Clean up globals #4217

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Clean up globals #4217

merged 3 commits into from
Nov 24, 2021

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Nov 22, 2021 •
edited
Loading

Summary

  • Removes unused tests that are no longer relevant
  • Removes unnecessary / unused variables on Engine singleton

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

Reviewers

@speigg @apolancojr

NateTheGreatt
NateTheGreatt approved these changes Nov 23, 2021
View reviewed changes
Copy link

@NateTheGreatt NateTheGreatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@HexaField HexaField merged commit c99fc9e into dev Nov 24, 2021
@HexaField HexaField deleted the clean-up-globals branch November 24, 2021 08:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NateTheGreatt NateTheGreatt NateTheGreatt approved these changes

@speigg speigg Awaiting requested review from speigg speigg is a code owner

@apolancojr apolancojr Awaiting requested review from apolancojr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HexaField @NateTheGreatt