Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Make Server Configs Editable #4234

Merged
merged 22 commits into from
Nov 26, 2021
Merged

Make Server Configs Editable #4234

merged 22 commits into from
Nov 26, 2021

Conversation

zulqarnainhanif
Copy link
Contributor

@zulqarnainhanif zulqarnainhanif commented Nov 23, 2021

Summary

Made the below fields editable:

Server:

  • gaTrackingId

Client:

  • logo
  • title

Email:

  • everything other than smsNameCharacterLimit

Authentication:

  • oauth.facebook.key
  • oauth.facebook.secret
  • oauth.github.key
  • oauth.github.secret
  • oauth.google.key
  • oauth.google.secret
  • oauth.linkedin.key
  • oauth.linkedin.secret
  • oauth.twitter.key
  • oauth.twitter.secret

AWS:

  • everything in sms

using below data from database instead of publicRuntimeConfig in client workspace

  • title (same as config.client.title; also, siteTitle should be removed and the places where siteTitle is used should be converted to title)
  • faviconXXpx/iconXXXpx
  • siteDescription
  • logo
  • auth. - these should be sourced from authentication.authStrategies

Added and used below configs

  • smsMagicLink in db configs
  • emailMagicLink in db configs

Updated the profile menu to reflect auth strategy enabled changes.
Updated different layouts meta link tags though helmet sourcing data through configs

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

#2704

Reviewers

@HexaField @barankyle

@barankyle
Copy link
Member

Looks like a good start. When I changed one of the auth keys and hit save, the JSON saved to the authentication.oauth column was mostly blank, but I'm sure that's a simple fix.

@zulqarnainhanif
Copy link
Contributor Author

Looks like a good start. When I changed one of the auth keys and hit save, the JSON saved to the authentication.oauth column was mostly blank, but I'm sure that's a simple fix.

yeap, server config, client config, authentication config are done and working fine now. moving on to aws and email.

@zulqarnainhanif zulqarnainhanif marked this pull request as ready for review November 23, 2021 23:17
@zulqarnainhanif zulqarnainhanif marked this pull request as draft November 25, 2021 18:58
@zulqarnainhanif zulqarnainhanif marked this pull request as ready for review November 25, 2021 21:01
@zulqarnainhanif zulqarnainhanif marked this pull request as draft November 26, 2021 08:46
zulqarnainhanif and others added 2 commits November 26, 2021 13:55
…able jwt toggle and add sms and email toggle in client section of admin settings
@zulqarnainhanif zulqarnainhanif marked this pull request as ready for review November 26, 2021 13:59
@barankyle barankyle merged commit f7de664 into dev Nov 26, 2021
@barankyle barankyle deleted the MakeConfigEditable branch November 26, 2021 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants