This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like a good start. When I changed one of the auth keys and hit save, the JSON saved to the authentication.oauth column was mostly blank, but I'm sure that's a simple fix. |
fix bug in update config of authentication panel of admin settings
yeap, server config, client config, authentication config are done and working fine now. moving on to aws and email. |
speigg
reviewed
Nov 25, 2021
packages/client-core/src/admin/components/Setting/Authentication.tsx
Outdated
Show resolved
Hide resolved
…h admin/settings -> client section
HexaField
approved these changes
Nov 25, 2021
…to authentication.seed.ts
…able jwt toggle and add sms and email toggle in client section of admin settings
mrhegemon
approved these changes
Nov 26, 2021
barankyle
approved these changes
Nov 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Made the below fields editable:
Server:
Client:
Email:
Authentication:
AWS:
using below data from database instead of publicRuntimeConfig in client workspace
Added and used below configs
Updated the profile menu to reflect auth strategy enabled changes.
Updated different layouts meta link tags though helmet sourcing data through configs
Checklist
npm run check
npm run lint
npm run test:packages
npm run build-client
References
#2704
Reviewers
@HexaField @barankyle