Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Editor project creation improvements #4236

Merged
merged 4 commits into from
Nov 25, 2021
Merged

Conversation

zulqarnainhanif
Copy link
Contributor

@zulqarnainhanif zulqarnainhanif commented Nov 23, 2021

Summary

Remove backdrop from modals
Fix label of create project modal
Make sure enter works when button is focused by pressing tab from input field
Add project in project grid after new project is created

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

#4210
#4213
#4214

Reviewers

@HexaField

@zulqarnainhanif zulqarnainhanif marked this pull request as ready for review November 23, 2021 20:05
@HexaField HexaField merged commit d38f1c4 into dev Nov 25, 2021
@HexaField HexaField deleted the EditorProjectCreationImprovements branch November 25, 2021 02:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants