This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Consolidate error logging #4263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speigg
force-pushed
the
consolidate-error-logging
branch
from
50e7384
to
82b5c89
Compare
barankyle
approved these changes
Nov 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some errors were being caught in try/catch blocks, displayed in a toast, and never printed to the console; now we pass entire error objects to
AlertService.dispatchAlertError(err)where the errors can be logged consistently.Checklist
npm run checknpm run lintnpm run test:packagesnpm run build-clientReferences
References to pertaining issue(s)
Reviewers
@HexaField @speigg @NateTheGreatt