Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Separate DB for tests #4362

Merged
merged 4 commits into from
Dec 4, 2021
Merged

Separate DB for tests #4362

merged 4 commits into from
Dec 4, 2021

Conversation

hanzlamateen
Copy link
Member

@hanzlamateen hanzlamateen commented Dec 3, 2021

Summary

This PR adds a separate database for running tests. This database will run in a separate container and will be initialized every time. The container for database will run on port 3305.

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

@HexaField @speigg @NateTheGreatt

Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, i think all that is left is to change npm run dev-reinit to npm run pretest in branch-build.yml so it runs in CI/CD to ensure the exact same process runs as when testing locally

package.json Outdated Show resolved Hide resolved
@HexaField HexaField merged commit cd78837 into dev Dec 4, 2021
@HexaField HexaField deleted the test-db branch December 4, 2021 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants