Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Dynamic Engine System Injection and Refactor #4368

Merged
merged 2 commits into from
Dec 4, 2021
Merged

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Dec 3, 2021

Summary

  • dynamic system injection
  • https://hostname/location/projectName/sceneName location resolving
  • system cleanup upon scene unload
  • pipelines are stored in groups of 6 instead of 2 relating to type rather than free/fixed

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

@HexaField @speigg @NateTheGreatt

@HexaField HexaField marked this pull request as ready for review December 4, 2021 01:09
@HexaField HexaField changed the title System injection can now be done at runtime Dynamic Engine System Injection and Refactor Dec 4, 2021
@HexaField HexaField merged commit 558e10b into dev Dec 4, 2021
@HexaField HexaField deleted the dynamic-system-injection branch December 4, 2021 22:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant