Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Functional Scene Loader Refactor #4369

Merged
merged 5 commits into from
Dec 5, 2021
Merged

Functional Scene Loader Refactor #4369

merged 5 commits into from
Dec 5, 2021

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Dec 4, 2021

Summary

Changes the scene loader to be entirely functional. Replace some callbacks with EngineEvents and simplifies the scene network object handling

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

#4311

QA Steps

  1. git checkout refactor-scene-loader
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

@HexaField @speigg @NateTheGreatt

@HexaField HexaField requested a review from speigg December 4, 2021 23:28
@HexaField HexaField marked this pull request as ready for review December 4, 2021 23:29
@HexaField HexaField merged commit 4d257ed into dev Dec 5, 2021
@HexaField HexaField deleted the refactor-scene-loader branch December 5, 2021 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant