Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Deleting package.json before npm installing cli and aws-sdk in GH actions #4431

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

barankyle
Copy link
Member

@barankyle barankyle commented Dec 10, 2021

Summary

npm will always install all of a found package.json's files even if you
want to just install one or two specific packages. This was greatly
slowing down the builder build process in GH actions. Removing the root
package.json resolves the issue, and that step takes mere seconds now.

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

@HexaField @speigg @NateTheGreatt

…ions.

npm will always install all of a found package.json's files even if you
want to just install one or two specific packages. This was greatly
slowing down the builder build process in GH actions. Removing the root
package.json resolves the issue, and that step takes mere seconds now.
@barankyle barankyle merged commit ecfb81a into dev Dec 10, 2021
@barankyle barankyle deleted the faster-ecr-prune-package-installation branch December 10, 2021 02:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant