Fixes in /admin/groups route and admin/user route fixes( user role update ) #5007
Conversation
|
@kimenyikevin admin user is unable to update role of other users as well now, need to fix that. |
|
@kimenyikevin pagination count of groups table is wrong
|
|
@kimenyikevin layout font sizes and spacing needs to be adjusted for View group
|
|
@HexaField how do we add more users in a group? |
| } | ||
|
|
||
| const scopeData: ScopeData[] = [] | ||
| adminScopeTypeState.scopeTypes.value.forEach((el) => { |
There was a problem hiding this comment.
you can use map here to declare and initialise the scopeData at the same time.
avoid usage of forEach as much as possible it use callback returns in the backend and doesn't stop execution.
| } | ||
|
|
||
| const scopeData: ScopeData[] = [] | ||
| adminScopeTypeState.scopeTypes.value.forEach((el) => { |
| @@ -184,81 +154,49 @@ const CreateUser = (props: Props) => { | |||
| }) | |||
| }) | |||
|
|
|||
| const staticResourceMenu: InputSelectProps[] = [] | |||
| staticResourceData.value.forEach((el) => { | |||
| }) | ||
|
|
||
| const userRoleData: InputSelectProps[] = [] | ||
| userRole.userRole.value.forEach((el) => { |
| @@ -174,6 +185,14 @@ const ViewUser = (props: Props) => { | |||
| }) | |||
| }) | |||
|
|
|||
| const userRoleData: InputSelectProps[] = [] | |||
| userRole.userRole.value.forEach((el) => { | |||
|
@kimenyikevin we are able to add same scope multiple times in the AutoComplete Component, fix that where ever AutoComplete Component is used. (Either disable selected one in the list or unselect them if already selected)
|
they need to be invited |
|
@kimenyikevin 1 small use-case Click view user Problem: The values are no reset in this case as the cancel should reset fields. This is working fine with groups. |
Summary
A summary of changes being made in this PR
Checklist
npm run checknpm run lintnpm run test:packagesnpm run build-clientReferences
References to pertaining issue(s)
QA Steps
git checkout pr_branch_namenpm installnpm run dev-reinitnpm run devList any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
Reviewers for this PR
Task to be complete