This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Avatar NPC Animations #5115
Merged
Avatar NPC Animations #5115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vatar-function-tests
…on/XREngine into avatar-function-tests
…vatar-function-tests
…vatar-npc-animations
…, editor init bug
…vatar-npc-animations
NPatel10
approved these changes
Feb 9, 2022
HexaField
added a commit
that referenced
this pull request
Feb 9, 2022
* Changes for common typings * client now uses server typings * added user types * added invite and invite type interfaces * Avatar NPC Animations (#5115) * set up avatar integration testing * make smaller functions * fix issue * temporary git push * refactor avatar functions, improve a bunch of avatar model handling * avatars load and animate in both editor and location, but have retargeting issue * fix user patching from location, avatar loop animation works properly, editor init bug * fix bug with processing loopable avatar model twice * fix bug with loading new loopable avatar model Co-authored-by: rondoor <webglsuperflow2021@gmail.com> * added analytics, create & update Bot, activeRoute types (#5076) * added analytics, create & update Bot, activeRout types * fix create and update bot when instance is null Co-authored-by: Josh Field <joshfield999@gmail.com> Co-authored-by: Kevin KIMENYI <kimenyikevin@gmail.com> * Distributed authority (#5120) * Add object authorized tag and related logic. * Rename NetworkObjectOwnedTag to NetworkObjectAuthorityTag. Discard any incoming network updates for objects that we have authority over. * Add network actions for requesting and transfer of network authority over an object. Integrate switching of authority with equippable objects. * Update test for new logic. Co-authored-by: Gheric Speiginer <gheric.speiginer@gmail.com> Co-authored-by: Josh Field <joshfield999@gmail.com> * Changes for common typings (#5049) * Changes for common typings * client now uses server typings * all typescript inherit from root * fix remaining types, disable client types for now * make test happy * remove old test Co-authored-by: HexaField <joshfield999@gmail.com> Co-authored-by: Zulqarnain Hanif <30355034+zulqarnainhanif@users.noreply.github.com> * fix merge error Co-authored-by: hanzlamateen <hanzlamateen@live.com> Co-authored-by: HexaField <joshfield999@gmail.com> Co-authored-by: Zulqarnain Hanif <30355034+zulqarnainhanif@users.noreply.github.com> Co-authored-by: rondoor <webglsuperflow2021@gmail.com> Co-authored-by: Kevin KIMENYI <kimenyikevin@gmail.com> Co-authored-by: Hamza Mushtaq <hamzamushtaq34@hotmail.com> Co-authored-by: Gheric Speiginer <gheric.speiginer@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allows models to have animations applied if they are avatars, and the avatar model animates in the editor and location appropriately.
Also fixes a few other problems with editor engine init and users being patched from a location breaking the editor.
Checklist
npm run checknpm run lintnpm run test:packagesnpm run build-clientReferences
References to pertaining issue(s)
QA Steps
git checkout pr_branch_namenpm installnpm run dev-reinitnpm run devList any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
Reviewers for this PR