-
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
…dd-generate-scene-cubemap
Rendering on the location side is pending
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when i try this, it is not rendering anything to the cubemap file, and the scene becomes invisible. i think we need to be using uploadBakeToServer
instead of just prepareSceneForBake
as there is more scene handling
I think the problem was in the upload function where getToken was still used and uploading to the server was failing with a not authenticated error. I have removed getToken you may check again. |
…dd-generate-scene-cubemap
Summary
while saving scene cubemap will be generated alongside a screenshot
Fixed error when scene preview button clicked without a scene loaded
A summary of changes being made in this PR
Checklist
npm run check
npm run lint
npm run test:packages
npm run build-client
References
#4869
References to pertaining issue(s)
QA Steps
git checkout pr_branch_name
npm install
npm run dev-reinit
npm run dev
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
Reviewers for this PR
@HexaField