Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

All Editor Scenes Generate Cubemap #5132

Merged
merged 13 commits into from
Feb 16, 2022
Merged

All Editor Scenes Generate Cubemap #5132

merged 13 commits into from
Feb 16, 2022

Conversation

FabriceIRANKUNDA
Copy link
Contributor

@FabriceIRANKUNDA FabriceIRANKUNDA commented Feb 9, 2022

Summary

while saving scene cubemap will be generated alongside a screenshot
Fixed error when scene preview button clicked without a scene loaded
A summary of changes being made in this PR

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

#4869
References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR
@HexaField

@FabriceIRANKUNDA FabriceIRANKUNDA linked an issue Feb 9, 2022 that may be closed by this pull request
2 tasks
NPatel10
NPatel10 previously approved these changes Feb 9, 2022
@FabriceIRANKUNDA FabriceIRANKUNDA marked this pull request as ready for review February 10, 2022 07:52
@NPatel10 NPatel10 dismissed their stale review February 11, 2022 02:53

Rendering on the location side is pending

Copy link
Member

@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when i try this, it is not rendering anything to the cubemap file, and the scene becomes invisible. i think we need to be using uploadBakeToServer instead of just prepareSceneForBake as there is more scene handling

@FabriceIRANKUNDA
Copy link
Contributor Author

when i try this, it is not rendering anything to the cubemap file, and the scene becomes invisible. i think we need to be using uploadBakeToServer instead of just prepareSceneForBake as there is more scene handling

I think the problem was in the upload function where getToken was still used and uploading to the server was failing with a not authenticated error. I have removed getToken you may check again.

@HexaField HexaField changed the title added generate cubemap alongside the scene screenshot All Editor Scenes Generate Cubemap Feb 16, 2022
@HexaField HexaField merged commit dd8ac2d into dev Feb 16, 2022
@HexaField HexaField deleted the add-generate-scene-cubemap branch February 16, 2022 09:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use cubemap for loading screen
3 participants