Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

typescript nonsense #5375

Merged
merged 2 commits into from
Mar 2, 2022
Merged

typescript nonsense #5375

merged 2 commits into from
Mar 2, 2022

Conversation

HexaField
Copy link
Member

Summary

typescript has some nonsense. i think my local environment is messed up. seeing if type checking passes here.

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@HexaField HexaField marked this pull request as ready for review March 2, 2022 03:10
@HexaField HexaField merged commit a628334 into dev Mar 2, 2022
@HexaField HexaField deleted the typescript-nonsense branch March 2, 2022 03:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant