Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Delete Project Properly #5381

Merged
merged 5 commits into from
Mar 4, 2022
Merged

Delete Project Properly #5381

merged 5 commits into from
Mar 4, 2022

Conversation

zulqarnainhanif
Copy link
Contributor

Summary

  • Close delete model after deleting project
  • Remove project files properly

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

#5298

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

@speigg @HexaField

@zulqarnainhanif zulqarnainhanif marked this pull request as ready for review March 3, 2022 11:41
@HexaField HexaField merged commit 9b83a56 into dev Mar 4, 2022
@HexaField HexaField deleted the DeletingProject branch March 4, 2022 03:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants