This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Removed use of gameserver subdomains in Mediasoup announcedIp. #5389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox can only make WebRTC connections to raw IP addresses; trying to connect to a domain will end in failure. Switched from using gameserver domain as announcedIp when in non-local mode to always using IP address. Commented out Route53 code and subdomain number since they are no longer needed.
barankyle
force-pushed
the
remove-subdomain-announcedip
branch
from
af66a58
to
3cfbe4c
Compare
HexaField
approved these changes
Mar 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Firefox can only make WebRTC connections to raw IP addresses; trying to connect
to a domain will end in failure. Switched from using gameserver domain as announcedIp
when in non-local mode to always using IP address.
Commented out Route53 code and subdomain number since they are no longer needed.
Checklist
npm run checknpm run lintnpm run test:packagesnpm run build-clientReferences
References to pertaining issue(s)
QA Steps
git checkout pr_branch_namenpm installnpm run dev-reinitnpm run devList any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
Reviewers for this PR