Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

CORS Proxy Scene Parser Handled Explicitly #5449

Merged
merged 3 commits into from
Mar 11, 2022
Merged

CORS Proxy Scene Parser Handled Explicitly #5449

merged 3 commits into from
Mar 11, 2022

Conversation

HexaField
Copy link
Member

@HexaField HexaField commented Mar 10, 2022

Summary

  • scene parser cors proxy explicit with identifier, not implicit with https://
  • editor has a button to add cors proxy to url

breaking changes:

  • client now needs VITE_CORS_SERVER_PORT env var
  • all scene using the cors proxy need to add __$cors-proxy$__ to the start of the appropriate values in scene json files

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

closes #5432

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@HexaField HexaField marked this pull request as ready for review March 10, 2022 04:27
@HexaField HexaField merged commit d33a0be into dev Mar 11, 2022
@HexaField HexaField deleted the cors-proxy-editor branch March 11, 2022 01:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change cors-proxy url replacement to be an editor option instead of backend scene parser
3 participants