This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Improve scene loading typings & fix loading race #5468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More accurate typings for scene data / metadata.
More accurate typings for scene service state, and more understandable action names.
Ensure that scene data is available before systems can initialize.
Move loading progress logic into EngineService receptor.
Use useHookedEffect in LoadEngineWithScene and NetworkInstanceProvisioning.
Summary
A summary of changes being made in this PR
Checklist
npm run check
npm run lint
npm run test:packages
npm run build-client
References
References to pertaining issue(s)
QA Steps
git checkout pr_branch_name
npm install
npm run dev-reinit
npm run dev
List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
Reviewers for this PR