Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Improve scene loading typings & fix loading race #5468

Merged
merged 7 commits into from
Mar 13, 2022
Merged

Conversation

speigg
Copy link
Member

@speigg speigg commented Mar 12, 2022

More accurate typings for scene data / metadata.
More accurate typings for scene service state, and more understandable action names.
Ensure that scene data is available before systems can initialize.
Move loading progress logic into EngineService receptor.
Use useHookedEffect in LoadEngineWithScene and NetworkInstanceProvisioning.

Summary

A summary of changes being made in this PR

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

More accurate typings for scene data / metadata.
More accurate typings for scene service state, and more understandable action names.
Ensure that scene data is available before systems can initialize.
Move loading progress logic into EngineService receptor.
Use useHookedEffect in LoadEngineWithScene and NetworkInstanceProvisioning.
@speigg speigg merged commit b544f8f into dev Mar 13, 2022
@HexaField HexaField deleted the scene-loading-fixes branch March 14, 2022 00:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants