Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

GLTF ECS Matrix Auto Update Bug Fixes #5492

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Conversation

HexaField
Copy link
Member

Summary

  • now parses gltf ecs data before applying matrix auto update, avoiding issues with physics objects being offset
  • gltf ecs entities use bitecs transform store
  • remove redundant second call to setup render settings

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@HexaField HexaField requested a review from hamzzam March 15, 2022 10:30
@hamzzam hamzzam merged commit 540d514 into dev Mar 15, 2022
@hamzzam hamzzam deleted the model-metadata-autoupdate-fixes branch March 15, 2022 10:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants