Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Remove ownerIndex from NetworkObjectComponent #5532

Merged
merged 1 commit into from
Mar 20, 2022

Conversation

HexaField
Copy link
Member

Summary

Slightly reduces complexity of netcode by reducing sources of truth for the userIndex of an object's owner, forcing the userIndex to be foudn via the ownerId on NetworkObjectComponent

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

@hamzzam hamzzam merged commit 432e324 into dev Mar 20, 2022
@hamzzam hamzzam deleted the remove-ownerIndex-NetworkObjectComponent branch March 20, 2022 09:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants