This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Improved some admin project modals #5537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HexaField
approved these changes
Mar 22, 2022
barankyle
force-pushed
the
project-update-improvements
branch
from
4382562
to
4646d75
Compare
FabriceIRANKUNDA
approved these changes
Mar 22, 2022
|
This PR might have conflicts with my PR which have styling changes for purple color scheme @HexaField . I have moved styling to scss in admin panel to cleanup some stuff. |
I'll wait for yours to get merged in and then rebase mine and fix any issues. |
barankyle
force-pushed
the
project-update-improvements
branch
from
ec40bf7
to
460542c
Compare
ConfirmModal now shows processing spinner and closes when finished. Fixed some visual bugs in project modals. Renamed a lot of things from 'Model' to 'Modal'. Fixed a number of misspellings of Conatiner -> Container. Disabled closing of scope selector when something is clicked.
barankyle
force-pushed
the
project-update-improvements
branch
from
460542c
to
5876cc7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ConfirmModal now shows processing spinner and closes when finished.
Fixed some visual bugs in project modals.
Renamed a lot of things from 'Model' to 'Modal'.
Fixed a number of misspelling of Conatiner -> Container
Checklist
npm run checknpm run lintnpm run test:packagesnpm run build-clientReferences
References to pertaining issue(s)
QA Steps
git checkout pr_branch_namenpm installnpm run dev-reinitnpm run devList any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.
Reviewers
Reviewers for this PR