Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Fixed issues with OAuth by moving app.set('host') and ('port') #5548

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

barankyle
Copy link
Member

@barankyle barankyle commented Mar 23, 2022

Summary

app.host and app.port need to be configured before authentication is configured, since it sets
the OAuth callback URLs from these values on setup.

Checklist

  • Pre-push checks pass npm run check
    • Linter passing via npm run lint
    • Unit & Integration tests passing via npm run test:packages
    • Docker build process passing via npm run build-client
  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

References

References to pertaining issue(s)

QA Steps

  1. git checkout pr_branch_name
  2. npm install
  3. npm run dev-reinit
  4. npm run dev

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Reviewers

Reviewers for this PR

app.host and app.port need to be configured before authentication is configured, since it sets
the OAuth callback URLs from these values on setup.
@HexaField HexaField merged commit 83cada6 into dev Mar 23, 2022
@HexaField HexaField deleted the app-host-setup-move branch March 23, 2022 23:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants